Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrency test #382

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix concurrency test #382

merged 2 commits into from
Dec 13, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Dec 13, 2024 •
edited
Loading

Problem

We're verifying the expected run results for concurrency tests by parsing the logs. This creates a brittle test as the log structure could change over time. This happened recently, breaking this test and causing a false positive.

Solution

Replace the verification via logs with a verification via run results.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Dec 13, 2024
@cla-bot cla-bot bot added the cla:yes label Dec 13, 2024
@mikealfare mikealfare marked this pull request as ready for review December 13, 2024 18:06
@mikealfare mikealfare requested a review from a team as a code owner December 13, 2024 18:06
@mikealfare
Copy link
Contributor Author

I tested this against dbt-postgres and it resolves the issue.

@mikealfare mikealfare enabled auto-merge (squash) December 13, 2024 19:13
@mikealfare mikealfare merged commit e3964d7 into main Dec 13, 2024
37 of 61 checks passed
@mikealfare mikealfare deleted the fix-concurrency-test branch December 13, 2024 20:31
VersusFacit pushed a commit that referenced this pull request Dec 16, 2024
@mikealfare @VersusFacit
Fix concurrency test (#382)
66dabc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @colin-rogers-dbt