Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily gate microbatch behind env var DBT_EXPERIMENTAL_MICROBATCH #308

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 14, 2024

resolves #N/A
docs dbt-labs/docs.getdbt.com/#N/A

Problem

  • If users have a custom incremental strategy named 'microbatch' the new builtin will cause it to break. We should gate it behind an env var temporarily, and eventually behind a behaviour change flag.
  • Should have been part of c36d156

Solution

  • gate adding "microbatch" to builtins unless environment variable is set
  • env var is already set in tests

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@MichelleArk MichelleArk added the skip:changelog-check Skip changelog verification in a PR label Sep 14, 2024
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Sep 14, 2024
@MichelleArk MichelleArk marked this pull request as ready for review September 14, 2024 03:59
@MichelleArk MichelleArk requested a review from a team as a code owner September 14, 2024 03:59
@MichelleArk MichelleArk changed the title gate microbatch behind os environment variable gate microbatch behind environment variable Sep 14, 2024
@MichelleArk MichelleArk changed the title gate microbatch behind environment variable Temporarily gate microbatch behind env var DBT_EXPERIMENTAL_MICROBATCH Sep 14, 2024
@QMalcolm QMalcolm merged commit 85292d3 into main Sep 16, 2024
17 checks passed
@QMalcolm QMalcolm deleted the gate-builtin-microbatch branch September 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA skip:changelog-check Skip changelog verification in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants