Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add freezegun to dbt-tests-adapter dependencies #305

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

MichelleArk
Copy link
Contributor

resolves #N/A
docs dbt-labs/docs.getdbt.com/#

Problem

Should have gone in as part of #300, as downstream adapters will need freezegun installed to run th microbatch tests.

example failure: dbt-labs/dbt-snowflake#1179

Solution

Add freezegun as dependency of dbt-test-adapters with permissive pinning (risk of breakage from a dependency here is very minimal)

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@MichelleArk MichelleArk requested a review from a team as a code owner September 12, 2024 16:29
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Sep 12, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk added the skip:changelog-check Skip changelog verification in a PR label Sep 12, 2024
@MichelleArk MichelleArk merged commit efed8a9 into main Sep 12, 2024
15 of 17 checks passed
@MichelleArk MichelleArk deleted the add-freezegun-dbt-test-adapters branch September 12, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA skip:changelog-check Skip changelog verification in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants