Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adap 821/support for redshift 821 #270

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Jul 22, 2024

This is a followon Pr to this core PR already merged

Problem

The Redshift PR here has no way for us to throw a user facing error in the case the unit test fixture cannot provide sufficient type interpolation data to redshift.

Solution

Add an abstract macro which Redshift can override as needed.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit requested a review from a team as a code owner July 22, 2024 23:33
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Jul 22, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@VersusFacit VersusFacit self-assigned this Jul 22, 2024
@VersusFacit VersusFacit added the Skip Changelog Skip changelog verification in a PR label Jul 22, 2024
@VersusFacit
Copy link
Contributor Author

If this needs a changelog, I can write up an issue ticket and add one but this is just opening a backdoor for other adapters as needed, so I'm not sure one is warranted.

@VersusFacit
Copy link
Contributor Author

VersusFacit commented Jul 23, 2024

The snowflake and postgres PR refs in this PR are further proof that the addition of the NO-OP macro worked for Redshift without breaking other adapters :)

@VersusFacit VersusFacit merged commit b088e51 into main Jul 23, 2024
15 of 17 checks passed
@VersusFacit VersusFacit deleted the ADAP-821/support_for_redshift_821 branch July 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA Skip Changelog Skip changelog verification in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants