Remove get_catalog_for_single_relation from sql/impl.py

[aranke]

Make consistent with calculate_freshness_from_metadata

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

I misread the PR

[mikealfare]

I think there's a decent number of adapters that would be able to just define the macro and go on from there, without needing to overwrite the method. In a sense, this is the equivalent of an abstract method for a SQLAdapter-based adapter. Is there a specific reason to remove this and fallback to the abstract method in BaseAdapter?

[aranke]

@mikealfare Is there an example of such an adapter?

[aranke]

@mikealfare Synced with @jtcohen6 offline, this macro needs to do some post-processing to return a CatalogTable object; I don't think a macro can directly return this.

Given this fact, I'd prefer to remove this stub here to imply that there's more work required for an adapter maintainer.

[mikealfare]

@mikealfare Synced with @jtcohen6 offline, this macro needs to do some post-processing to return a CatalogTable object; I don't think a macro can directly return this.

Given this fact, I'd prefer to remove this stub here to imply that there's more work required for an adapter maintainer.

Ah, yes. I just looked at the dbt-snowflake implementation in your PR and there's quite a bit more logic there than the stub suggests. In that case I agree for two reasons. The stub will never be used and the presence of the stub is misleading.

In that case, can we also remove the related module variable for the macro name? I don't think it's used anywhere else.

[aranke]

@mikealfare good call-out, done!