Make get_catalog_for_single_relation
a concrete method in BaseAdapter
#240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
dbt-adapters==1.3.0
had to be yanked because adapters didn't implement the new abstract methodget_catalog_for_single_relation
.This method should be opt-in, so adapters shouldn't need to implement this.
Solution
Make the
get_catalog_for_single_relation
concrete inBaseAdapter
so adapters can default to this implementation.Sample PR with passing tests in
dbt-bigquery
that has not implemented this capability: dbt-labs/dbt-bigquery#1262Checklist