Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support unit test sql format #146

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Changes to support unit test sql format #146

merged 4 commits into from
Apr 11, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Apr 8, 2024

Support for resolving #9405

Handles sql strings in a unit test in addition to dictionaries and csv files

Copy link

github-actions bot commented Apr 8, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests(I guess only integration in this case) to capture this behavior?

@ChenyuLInx
Copy link
Contributor

Oh I see tests here

Copy link

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out, and looks good!

@gshank gshank merged commit 3f2386d into main Apr 11, 2024
11 checks passed
@gshank gshank deleted the unit_test_sql_format branch April 11, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants