-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazy load agate and add TYPE_CHECKING
#126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for raising this! Really interesting, we will probably want to cascade out to our implementing adapters as well |
Yep, that will be the next step. I'll get to your comment re: formatting changes, I think that must have been something with the pre-commit setup. |
dwreeves
force-pushed
the
speed-up-cli
branch
2 times, most recently
from
March 26, 2024 03:51
f3f927c
to
b930829
Compare
…ers into speed-up-cli
Fixed |
colin-rogers-dbt
approved these changes
Mar 26, 2024
This was referenced Mar 27, 2024
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #125
This PR is related to the following open PR in dbt-core: #9744
TLDR: lazy-loading
agate
speeds up the load time of dbt by about 3.5%. Most instances ofagate
are unnecessary as dbt only uses it in a select few situations, and most instances ofagate
can be placed behindTYPE_CHECKING
.You can check that this works as intended by doing the following:
Checklist