Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the entirety of dbt-tests-adapter into the dbt-tests-adapter directory #118

Merged
merged 38 commits into from
Mar 1, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

hatch makes a lot of assumptions about where files are relative to each other. In particular, it prefers one package per repo.

Solution

Instead of nesting the namespace packages together, move the dbt-tests-adapter package into its own directory, isolated from everything else.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Feb 29, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
dbt/adapters/__about__.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
dbt-tests-adapter/pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release_prep_hatch.yml Show resolved Hide resolved
.github/workflows/release_prep_hatch.yml Show resolved Hide resolved
dbt-tests-adapter/dbt/__init__.py Outdated Show resolved Hide resolved
@mikealfare mikealfare merged commit 7620c4f into main Mar 1, 2024
7 checks passed
@mikealfare mikealfare deleted the isolate-dbt-tests-adapter branch March 1, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants