Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Record/Replay of Queries #107

Closed
wants to merge 9 commits into from
Closed

Support Record/Replay of Queries #107

wants to merge 9 commits into from

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Feb 26, 2024

Resolves core issue dbt-labs/dbt-core#9669

The overall feature is complex, so see the above issue for details. This PR adds support for the record/replay mechanism for many(still not all) queries going through adapters.

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@cla-bot cla-bot bot added the cla:yes label Apr 25, 2024
@peterallenwebb peterallenwebb changed the title Paw/record Support Record/Replay of Queries Apr 26, 2024
@peterallenwebb peterallenwebb marked this pull request as ready for review April 26, 2024 19:41
@@ -1,6 +0,0 @@
# N.B.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure we need these files...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Agreed. I removed these for debugging purposes while working on this a couple months ago, but will make sure these are not deleted in the final Pr.

@peterallenwebb
Copy link
Contributor Author

Closing in favor of #195

@peterallenwebb peterallenwebb deleted the paw/record branch May 16, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants