Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Standardize cancellation behavior via functional tests #611

Open
3 tasks done
benc-db opened this issue Jan 21, 2025 · 0 comments
Open
3 tasks done

[Feature] Standardize cancellation behavior via functional tests #611

benc-db opened this issue Jan 21, 2025 · 0 comments
Labels
feature:adapter_maintenance feature:unit-tests Issues related to built-in dbt unit testing functionality type:enhancement New feature request

Comments

@benc-db
Copy link

benc-db commented Jan 21, 2025

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Adapter developers should have some standard of behavior to develop against when it comes to cancelling an in progress run. There is not a generic functional test for this behavior, but is there is a functional test for BigQuery. Without this test, it is unclear to adapter developers what expected cancellation behavior looks like. For example, you could let all executing queries complete but not allow any further queries, vs cancelling cursors, vs both.

Describe alternatives you've considered

No response

Who will this benefit?

All users, as adapter behavior becomes more consistent, and adapter developers, as the expected behavior is crystalized in a functional test.

Are you interested in contributing this feature?

No response

Anything else?

No response

@benc-db benc-db changed the title [Feature] Standardized cancellation behavior via functional tests [Feature] Standardize cancellation behavior via functional tests Jan 21, 2025
colin-rogers-dbt pushed a commit that referenced this issue Feb 3, 2025
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@amychen1776 amychen1776 added type:enhancement New feature request feature:unit-tests Issues related to built-in dbt unit testing functionality feature:adapter_maintenance labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:adapter_maintenance feature:unit-tests Issues related to built-in dbt unit testing functionality type:enhancement New feature request
Projects
None yet
Development

No branches or pull requests

2 participants