-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query recording for adapters which use SQLConnectionManager #195
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spell checked. Otherwise looks good but you'll need a codeowner to approve.
@colin-rogers-dbt asked a question about performance in a separate channel, which I'll answer here: This will not have any impact on runtime performance when neither record or replay mode is in use. In those cases, the function annotations simply return the function unmodified, so it as if there was no annotation at all, and runtime behavior should be unchanged. |
grammar/spelling Co-authored-by: Emily Rockman <[email protected]>
Resolves, in part, core issue dbt-labs/dbt-core#9669
The overall feature is complex, so see the above issue for details. This PR adds support for the record/replay mechanism for queries executed using the execute() function on SQLConnectionManager. This is just a starting point for more complete record/replay of DWH interaction.
Checklist