-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve get missing filepaths
utils logic
#105
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 45 47 +2
Lines 2041 2584 +543
Branches 252 272 +20
==========================================
+ Hits 2041 2584 +543
... and 42 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@BAntonellini, is this improvement intended to resolve #101? I found that pinning our pre-commit hooks to c3c3f1d resolved the issue, but didn't know if that was what you had in mind. I did notice a seemingly transient
|
@katieclaiborne thanks for pointing that issue out, this PR is originally intended to solve what was proposed on PR #99 I've just committed a fix that should solve what you mentioned, as it's related with all these changes. Could you please try with 3a31b0b ? Thank you |
That worked! Thank you, Bruno. Did I also see you mention that v1.1 would be released this week? |
90e2462
to
3a31b0b
Compare
Great to hear that! Yes, we are working some final details, and will release 1.1 |
Replaced simple string work of
get_missing_file_paths
utils function for a proper pathlib.Path approach.With these: