-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add toolbox for ar compress and uncompress #529
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage ? 55.03%
=======================================
Files ? 72
Lines ? 13897
Branches ? 61
=======================================
Hits ? 7648
Misses ? 6249
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…_ar_toolbox # Conflicts: # src/node/src/rollup_executor.rs
let mut mutations = Vec::new(); | ||
let payloads = record_batch | ||
.column_by_name("payload") | ||
.unwrap() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unwrap will panic if some error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Movivation
In this CR we are going to provide a AR toolbox for AR operations including upload/download , parquet compress and parse. etc.
This is a part of work for coldstart and recover #471
PR-Codex overview
This PR focuses on introducing an
ArToolBox
module and refactoring theRollupExecutor
module.Detailed summary
ArToolBox
module for handling Arweave related operations.RollupExecutor
to useArToolBox
for compressing and uploading record batches.