Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension v2 #42

Merged
merged 82 commits into from
Feb 26, 2025
Merged

Extension v2 #42

merged 82 commits into from
Feb 26, 2025

Conversation

devhawk
Copy link
Collaborator

@devhawk devhawk commented Feb 7, 2025

Major Changes

  • Adds support for TS v2 API
  • Adds replay / replay cloud debugging (depends on Transact-TS v2.3)
  • Removes configuration settings for provenance DB in favor of parsing dbos-config.yaml file + retrieving data from DBOS cloud
  • Uri Handler Debugging removed for now. Will be re-enabled when appropriate links can be added to cloud console
  • Note, Time Travel Debugging depends on an unreleased DBOS cloud update that adds provenance DB to the <userName>/applications/[<appName]> endpoints
  • Significant architecture redesign

fixes #32

@devhawk devhawk marked this pull request as ready for review February 24, 2025 19:09
@chuck-dbos chuck-dbos self-requested a review February 25, 2025 16:16
@chuck-dbos chuck-dbos self-requested a review February 25, 2025 18:00
@qianl15
Copy link
Member

qianl15 commented Feb 25, 2025

Tested with the latest version and it works well!
A nit: when there's a database connection issue, can we print out more error messages?
Today, I first had a hard time connecting to my local DB, and then I realized the password setting was wrong. It'd be helpful to display the actual DB connection error.

[error] #getDbClient Failed to connect to database localhost:5432/dbos_node_toolbox_dbos_sys {"error":{}}

Screenshot 2025-02-25 at 2 57 40 PM

Copy link
Member

@qianl15 qianl15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this PR when you feel ready.

@devhawk
Copy link
Collaborator Author

devhawk commented Feb 26, 2025

Tested with the latest version and it works well! A nit: when there's a database connection issue, can we print out more error messages? Today, I first had a hard time connecting to my local DB, and then I realized the password setting was wrong. It'd be helpful to display the actual DB connection error.

FYI, we do write the actual connection error to the DBOS output log, but I can surface it in the error message as well

image

@devhawk
Copy link
Collaborator Author

devhawk commented Feb 26, 2025

new error message window:
image

Note, you do need to expand the error window to see the entire message

@devhawk devhawk merged commit f2c6f43 into main Feb 26, 2025
2 checks passed
@devhawk devhawk deleted the devhawk/v2-update branch February 26, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support local debug mode (no proxy)
3 participants