Fix slack-ruby#78: ping thread terminates on a failed restart.

dblock · Sep 18, 2018 · ffed047 · ffed047
1 parent 861d974
commit ffed047
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/slack-ruby-bot-server/ping.rb b/lib/slack-ruby-bot-server/ping.rb
@@ -68,7 +68,6 @@ def down!
       @error_count += 1
       return true if retries_left?
       restart!
-      false
     end
 
     def restart!
@@ -80,8 +79,11 @@ def restart!
       end
       driver.close
       driver.emit(:close, WebSocket::Driver::CloseEvent.new(1001, 'bot offline'))
+      false
     rescue StandardError => e
       logger.warn "Error restarting team #{owner.id}: #{e.message}."
+      logger.error e
+      true
     end
 
     def ping_interval