Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to turn off gifs #101

Closed
tinkone opened this issue Apr 8, 2016 · 7 comments
Closed

Unable to turn off gifs #101

tinkone opened this issue Apr 8, 2016 · 7 comments
Labels

Comments

@tinkone
Copy link

tinkone commented Apr 8, 2016

pongbot set gifs off appears to be broken, the return response is invalid. And gifs continue to be shown.

@dblock
Copy link
Owner

dblock commented Apr 8, 2016

(Re)tested which worked for me, but I see an error in the logs. I don't see the stack for it, so a bit hard to debug. Does your team start with "365"? Otherwise what's the team name?

Are you typing this in a channel? Care to screenshot it?

Try a few variations:

  • @pongbot: set gifs off
  • @pongbot set gifs off

Or DM the bot

  • set gifs off

Same error?

@dblock dblock added the bug? label Apr 8, 2016
@tinkone
Copy link
Author

tinkone commented Apr 8, 2016

Yeah the team name starts with 365, I just DM the bot with set gifs off still get the invalid message back. Here's the screen cap, hope it brings some clarity

screen shot 2016-04-08 at 8 50 23 am

@dblock
Copy link
Owner

dblock commented Apr 8, 2016

Does set gifs return anything or also errors out?

@dblock
Copy link
Owner

dblock commented Apr 8, 2016

I've made some logging improvements in production, do try again, that should help with locating the problem. Appreciate your patience.

@tinkone
Copy link
Author

tinkone commented Apr 8, 2016

Hey that seems to fix it. I can set it on and off now. Sweet!

@dblock
Copy link
Owner

dblock commented Apr 9, 2016

Strange. I didn't change any code around setting these, something must still be an issue. I'll close this for now.

@dblock
Copy link
Owner

dblock commented Apr 23, 2016

This should be now fixed, see #102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants