Fix #35: incorrect ranking and broken leaderboard after first game fo…

…llowing a reset.

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2015-10-06 11:38:17 -0400 using RuboCop version 0.34.2.
+# on 2015-10-06 13:22:25 -0400 using RuboCop version 0.34.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -28,20 +28,20 @@ Lint/RescueException:
   Exclude:
     - 'config.ru'
 
-# Offense count: 20
+# Offense count: 21
 Metrics/AbcSize:
   Max: 37
 
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 117
+  Max: 118
 
 # Offense count: 4
 Metrics/CyclomaticComplexity:
   Max: 11
 
-# Offense count: 246
+# Offense count: 250
 # Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
   Max: 209

CHANGELOG.md

@@ -1,5 +1,6 @@
 ### Changelog
 
+* [#35](https://github.com/dblock/slack-gamebot/issues/35): Fix: missing ranking and broken leaderboard in first game after reset - [@dblock](https://github.com/dblock).
 * [#34](https://github.com/dblock/slack-gamebot/issues/34): Fix: `season` incorrectly reports no seasons after reset - [@dblock](https://github.com/dblock).
 * Fix: correctly handle `user_change` event - [@dblock](https://github.com/dblock).
 * [#29](https://github.com/dblock/slack-gamebot/issues/29): Fix: `season` incorrectly reports number of players - [@dblock](https://github.com/dblock).

slack-gamebot/models/challenge.rb

@@ -95,6 +95,7 @@ def lose!(loser, scores = nil)
     Match.create!(challenge: self, winners: winners, losers: losers, scores: scores)
     winners.inc(wins: 1)
     losers.inc(losses: 1)
+    User.rank!
     update_attributes!(state: ChallengeState::PLAYED)
   end
 

spec/fabricators/match_fabricator.rb

@@ -8,6 +8,7 @@
   after_create do |match|
     match.winners.inc(wins: 1)
     match.losers.inc(losses: 1)
+    User.rank!
     challenge.update_attributes!(state: ChallengeState::PLAYED, updated_by: match.losers.first)
   end
 end

spec/models/season_spec.rb

@@ -15,10 +15,10 @@
       expect(User.all.detect { |u| u.wins != 0 || u.losses != 0 }).to be nil
     end
     it 'saves user ranks' do
-      expect(season.user_ranks.count).to eq 4
+      expect(season.user_ranks.count).to eq 6
     end
     it 'to_s' do
-      expect(season.to_s).to eq "#{season.created_at.strftime('%F')}: #{season.send(:winner).user_name}: 1 win, 0 losses (elo: 48), 3 matches, 4 players"
+      expect(season.to_s).to eq "#{season.created_at.strftime('%F')}: #{season.send(:winner).user_name}: 1 win, 0 losses (elo: 48), 3 matches, 6 players"
     end
   end
   context 'without challenges' do
@@ -28,11 +28,18 @@
       expect(season.errors.messages).to eq(challenges: ['No matches have been recorded.'])
     end
   end
-  context 'current season' do
+  context 'current season with one match' do
+    let!(:match) { Fabricate(:match) }
+    let(:season) { Season.new }
+    it 'to_s' do
+      expect(season.to_s).to eq "Current: #{season.send(:winner).user_name}: 1 win, 0 losses (elo: 48), 1 match, 2 players"
+    end
+  end
+  context 'current season with multiple matches' do
     let!(:matches) { 3.times.map { Fabricate(:match) } }
     let(:season) { Season.new }
     it 'to_s' do
-      expect(season.to_s).to eq "Current: #{season.send(:winner).user_name}: 1 win, 0 losses (elo: 48), 3 matches, 4 players"
+      expect(season.to_s).to eq "Current: #{season.send(:winner).user_name}: 1 win, 0 losses (elo: 48), 3 matches, 6 players"
     end
     context 'with an unplayed challenge' do
       before do