Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend Enumerable #5

Merged
merged 1 commit into from
Jun 3, 2014
Merged

extend Enumerable #5

merged 1 commit into from
Jun 3, 2014

Conversation

kgann
Copy link
Contributor

@kgann kgann commented Jun 3, 2014

Extend Enumerable to take advantage of other methods (reduce, take, sort_by, any?, all? etc...)

@@ -1,6 +1,6 @@
### Next

* Your contribution here.
* Mixed in `Enumerable` - [@kgann](https://github.com/kgann).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the previous comment in please :-)

@dblock
Copy link
Owner

dblock commented Jun 3, 2014

Much better. Will merge and cut a release.

@kgann
Copy link
Contributor Author

kgann commented Jun 3, 2014

@dblock

  • comment replaced
  • rebased
  • fixed latest build failure
    • needed to extend Enumerable before ClassMethods since Enumerable in Ruby 2.1+ implements #to_h

@dblock
Copy link
Owner

dblock commented Jun 3, 2014

Perfect.

dblock added a commit that referenced this pull request Jun 3, 2014
@dblock dblock merged commit 7d4d7cd into dblock:master Jun 3, 2014
@dblock
Copy link
Owner

dblock commented Jun 29, 2014

Fyi, I release 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants