Adds support to subclass an Ruby::Enum #13
Conversation
All subclasses of type S that inherit from type T should have all enums defined in parent class T.
laertispappas
force-pushed
the
lp/subclassing
branch
from
1e8c300 to
90b8582
Compare
|
Looks like the build needs to lock down Rake, http://stackoverflow.com/questions/35893584/nomethoderror-undefined-method-last-comment-after-upgrading-to-rake-11. |
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| * Your contribution here. | |||
|
|
|||
| ### 0.6.1 (Next) | |||
There was a problem hiding this comment.
There's one just like that above, remove.
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| * Your contribution here. | |||
|
|
|||
| ### 0.6.1 (Next) | |||
|
|
|||
| * [#3](https://github.com/dblock/ruby-enum/pull/13): Adds support for sub classing an Enum- [@laertispappas](https://github.com/laertispappas). | |||
lib/ruby-enum/enum.rb
Outdated
| @@ -43,8 +45,10 @@ def validate_value!(value) | |||
| end | |||
|
|
|||
| def const_missing(key) | |||
| if @_enum_hash[key] | |||
| if @_enum_hash && @_enum_hash[key] | |||
There was a problem hiding this comment.
Maybe .key?(key)? I believe it's faster. Otherwise assign first to avoid the double lookup:
r = @_enum_hash[key] if @_enum_hash
if r
r.value
elsif ...Given a class S where the method define is not called, @_enum_hash will be nil. In order to not raise a undefined method [] for nil class in const_missing I added the behavior to check for the presence if the `@_enum_hash` first before trying to access the enums hash.
laertispappas
force-pushed
the
lp/subclassing
branch
from
90b8582 to
014c4e7
Compare
|
Thanks for the feedback. I have reviewed the changes and rebased interactive. Why did the build brake now with this commits? Shouldn't it have broken on previous builds as well? |
|
There was a new release of Rake, and we didn't lock anything here. |
| @@ -1,6 +1,6 @@ | |||
| ### 0.6.1 (Next) | |||
|
|
|||
| * Your contribution here. | |||
|
One more small thing in changelog ... Do you want to help out with this gem? Would love to give you r/w access and rubygems to make a release (what's your rubygems email?). |
Rake 11.0.1 removes the last_comment method which Rails 2.3 rspec-core (< 3.4.4) uses. Therefore until/if a patch is released we need to pin rake to an older version in Gemfile:
laertispappas
force-pushed
the
lp/subclassing
branch
from
014c4e7 to
8af36ee
Compare
|
@dblock Sure I will to my best. [email protected] |
This PR addresses the feature described in #3. Ruby::Enum now supports subclassing by inheriting all enums defined in the parent class. New enums may be defined in subclasses of course. I also made fixed some typos in the README and fixed the code to raise the correct exception when a Ruby::Enum class has not defined any enums (empty class ).