Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: svg icon issues with fill #267

Merged
merged 4 commits into from
Feb 27, 2023
Merged

fix: svg icon issues with fill #267

merged 4 commits into from
Feb 27, 2023

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Feb 27, 2023 •
edited
Loading

Resolves #265

@mfranzke mfranzke added this to the Release 1.0 milestone Feb 27, 2023
@mfranzke mfranzke self-assigned this Feb 27, 2023
@mfranzke mfranzke linked an issue Feb 27, 2023 that may be closed by this pull request
SVG Icon Issues with Fill #265
Closed
@mfranzke mfranzke requested a review from annsch as a code owner February 27, 2023 07:08
@mfranzke mfranzke enabled auto-merge (squash) February 27, 2023 07:09
@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/base/review/265-svg-icon-issues-with-fill

@shartte
Copy link
Contributor

shartte commented Feb 27, 2023

Before you merge this: Should we make this an automated step? (The transform of the original SVG files)

@mfranzke mfranzke mentioned this pull request Feb 27, 2023
Open
@mfranzke
Copy link
Member Author

mfranzke commented Feb 27, 2023 •
edited
Loading

Before you merge this: Should we make this an automated step? (The transform of the original SVG files)

I like this idea, but would keep it separate to this change; I've opened another ticket for this.

@mfranzke mfranzke merged commit 5a48e1f into main Feb 27, 2023
@mfranzke mfranzke deleted the 265-svg-icon-issues-with-fill branch February 27, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
improvement
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.

SVG Icon Issues with Fill
3 participants
@mfranzke @shartte @nmerget