Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis build #4

Merged
merged 3 commits into from
May 27, 2018
Merged

Fix travis build #4

merged 3 commits into from
May 27, 2018

Conversation

arturcic
Copy link

Fixed the travis build. travis build

Appveyour works as well appveyour build

@arturcic arturcic changed the title Feature/netstandard Fix travis build May 23, 2018
@dazinator
Copy link
Owner

Have taken a look. With the change to msbuild does this mean that we are back to using mono on linux in order to build? Or does msbuild on linux use dotnet core? Wondering if mono can be removed :-)

@dazinator
Copy link
Owner

I think it's probably safe to merge this given you have fixed the broken travis build and added the test filter! We can work out the mono dependency stuff seperately later.

@dazinator dazinator merged commit 4a5356b into dazinator:feature/netstandard May 27, 2018
@arturcic arturcic deleted the feature/netstandard branch May 28, 2018 09:05
@arturcic
Copy link
Author

@dazinator
Copy link
Owner

Thanks - so looking at that it does seem to depend on mono: https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/MSBuild/MSBuildResolver.cs#L17

Msbuild is also available under .net core now: https://github.com/Microsoft/msbuild which means a mono install would be unnecessary - something we can look at seperately later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants