Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only named exports may use 'export type' #187

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: Only named exports may use 'export type' #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/type-util/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export * from './type-util';
export type * from './type-util.type';
export { TypeUtil } from './type-util';
export type { NarrowableType, PickWithPartial, RequiredPartialProps, Nullable, Arrayable } from './type-util.type';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type 빼고 export * 로 써도 되지않나요?

Copy link
Contributor Author

@TaehuiKim TaehuiKim Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하지만 저친구들은 그저 타입이니77ㅏ... 흠
일단 이거 빌드 오류때문이라 병합하고 생각해볼게여

Copy link
Contributor Author

@TaehuiKim TaehuiKim Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microsoft/TypeScript#52217
더 보다 보니 나중 버전에는 지원하는 것 같아요
ts 버전이 5버전대로 올라가면 자연스럽게 해결 될 문제인걸로 보여요!