Accept api_key and send pebblo-server's response to daxa cloud. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-trip
commented
Mar 21, 2024
•
rahul-trip
commented
- Added support for api_key for daxa cloud
- response of pebblo-server's loader/doc api call is now sent to daxa-cloud loader/doc api call as a payload.docs
- timeout for loader/doc post call to pebblo-server is now increased to 300 seconds
rahul-trip
force-pushed
the
rahul_pebblo_daxa_Api_key
branch
2 times, most recently
from
4cdfd74 to
1b31682
Compare
srics
changed the title
rahul-trip
force-pushed
the
rahul_pebblo_daxa_Api_key
branch
from
c2ebcfe to
ce8a77a
Compare
rahul-trip
changed the title
rahul-trip
force-pushed
the
rahul_pebblo_daxa_Api_key
branch
from
ce8a77a to
d45a985
Compare
Raj725
force-pushed
the
googledrive_identity_loader
branch
from
5405879 to
55234be
Compare
Raj725
reviewed
Mar 28, 2024
| daxa_response.json(), | ||
| ) | ||
| except requests.exceptions.RequestException: | ||
| logger.warning("Unable to reach Daxa cloud server.") |
There was a problem hiding this comment.
Use of "Daxa" and "Pebblo" interchangeably is confusing.
- Url(202) => pebblo_cloud_url
- Response(203) => daxa_response
- Warn log(218) => Daxa cloud server
| len {len(resp.request.body if resp.request.body else [])} \ | ||
| response status{resp.status_code} body {resp.json()}" | ||
| ) | ||
| "send_loader_doc: request url %s, body %s len %s response status %s\ |
There was a problem hiding this comment.
Is there a specific reason for switching from f-string formatting to %-formatting?
There was a problem hiding this comment.
Yes, when logging it is recommended to use lazy strings, meaning the string formatting will only get evaluated if the logging string will get put out. E.g. a message with logging level debug won't get evaluated when the logging level is set to information or higher.
refer: https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/logging-not-lazy.html
|
please fix lint errors |
rahul-trip
force-pushed
the
googledrive_identity_loader
branch
from
55234be to
f30bc52
Compare
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul_pebblo_daxa_Api_key
branch
2 times, most recently
from
bc759f8 to
121d31f
Compare
rahul-trip
force-pushed
the
googledrive_identity_loader
branch
from
f30bc52 to
39e2a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.