-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#113] Filter workers by their last job status #173
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rhian-cs Would u mind posting a print screen of the final result? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhian-cs Can u add the changes you're adding in the CHANGELOG.md file?
/* === INPUT LIST === */ | ||
|
||
#status_filters_checkboxes { | ||
display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind keeping an indentation of 2 spaces?
end | ||
|
||
def filter_last_job_status(status) | ||
display.select { |worker| worker[:last_job_status] == status } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u try to feed a huge number of data into Redis just to allow us to identify performance issues here?
…nce and updating its tests
1323320
to
00d7c93
Compare
@wenderjean @davydovanton Hey everyone! I just rebased this PR and fixed the conflicts. When you have a bit of time, would you mind reviewing it? |
Added a way to filter workers by their last_job_status properties (as requested in #113) both in the API and in the statistics web page. Tests for the API and the called methods are also included.
API:
/sidekiq/api/statistic_by_last_job_status.json
Web page
In
/sidekiq/statistic
Worker's table I added two checkboxes (Passed and Failed) to show/hide the workers in the table depending on their last job status.