Remove support for Logs feature #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenderjean
force-pushed
the
fix/remove-support-for-logs-feature
branch
from
be1a2a1 to
0e1762f
Compare
|
Any plan to release this? |
|
@fabn I fixed a tag for version |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Changes
Rationale
Even though we can use the process manager to redirect logs to a file, the Sidekiq process itself logs only to STDOUT. Recently I began to question the usability of reading logs in Statistic pages, I mean, for a development environment usually, we may want to see the real-time STDOUT and for higher ones, I'd dare to say that we're usually using a specialized log tracking like Sentry, for example.
I'm also opened to any other strong opinion about it.
Tasks
2.0.0(should be a major one)