Allow passing additional options directly to GRPC clients #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful, for example, to configure max message size, which is now possible via
```
Etcdv3::Connection.new('http://localhost:2379', 10, nil, :client_options => { :channel_args => { GRPC::Core::Channel::MAX_MESSAGE_LENGTH => 16*1024*1024 } })
```
|
Does anybody maintain this repo? Merging this PR will solve my problem with etcd, for now I need either to monkeypatch it or use my own gem :( |
|
Sorry I missed this. I'll take a look. |
|
Cut a new release to include these changes. |
t0ch1k
added a commit
to t0ch1k/etcdv3-ruby
that referenced
this pull request
Nov 19, 2023
…vissp14#139)" This reverts commit b946b42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful, for example, to configure max message size, which is now possible via