Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing zero-byte reference when using namespace #135

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

davissp14
Copy link
Owner

@davissp14 davissp14 commented Aug 2, 2021

Honor the namespace when using zero byte. This will intercept any zero-byte references and rewrite them to target everything under the current namespace..

Addressing: #136

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #135 (59a237f) into master (a69267f) will decrease coverage by 0.03%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   99.17%   99.14%   -0.04%     
==========================================
  Files          39       39              
  Lines        2072     2096      +24     
==========================================
+ Hits         2055     2078      +23     
- Misses         17       18       +1     
Impacted Files Coverage Δ
lib/etcdv3/namespace/kv/requests.rb 95.83% <83.33%> (-4.17%) ⬇️
spec/etcdv3_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a69267f...59a237f. Read the comment docs.

@davissp14 davissp14 merged commit 321ab7b into master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant