Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP version comparison #1

Merged
merged 1 commit into from
May 5, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,8 @@ public function printDebugInfo()
*/
public function createConnection($wsdl, $proxy = null, $soap_options = array())
{
// We don't need to parse out any subversion suffix - e.g. "-01" since
// PHP type conversion will ignore it
$phpversion = substr(phpversion(), 0, strpos(phpversion(), '-'));
if ($phpversion < 5.3) {
// use correct version comparison
if (version_compare(phpversion(), '5.3', '<')) {
throw new Exception ('PHP versions older than 5.3 are no longer supported. Please upgrade!');
}

Expand Down