Add GH Actions CI and fix tests on Erlang 27 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickva
force-pushed
the
add-some-ci
branch
24 times, most recently
from
38d92b5
to
0ebc7c2
Compare
Add CI for Windows, MacOS and Ubuntu Linux. For Linux, test both rebar2 and rebar3. Apparently due to `string:split/2` in `rebar.config.script` jiffy wasn't compatible with Erlang <20 for quite a now, and we didn't see any complaints, so make Erlang 20 the minimum supported version. Old jiffy releases are still available for anyone who needs them. In addition, only Erlang OTP docker images 20+ work with the latest (v4) checkout CI action, so that's another reason to make that the new cutoff. On Erlang 27 needed to make a few test updates: * The referenced binary length size computation changed so make sure to make the binaries large enough to avoid triggering the inconsistencies between <27 and 27+ version and needing to do an ifdef of some sort. * In Erlang 27 -0.0 =/= 0.0 so updated a few tests expecting exact comparison, to use numeric equality `=`. Jiffy doesn't round-trip -0.0s anyway, so it's only a test-side discrepancy.
nickva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI for Windows, MacOS and Ubuntu Linux. For Linux, test both rebar2 and rebar3.
Apparently due to
string:split/2inrebar.config.scriptjiffy wasn't compatible with Erlang <20 for quite a while now, and we didn't see any complaints, so make Erlang 20 the minimum supported version. Old jiffy releases are still available for anyone who needs them. In addition, only Erlang OTP docker images 20+ work with the latest (v4) checkout CI action, so that's another reason to make that the new cutoff.On Erlang 27 needed to make a few test updates:
The referenced binary length size computation changed so make sure to make the binaries large enough to avoid triggering the inconsistencies between <27 and 27+ version and needing to do an ifdef of some sort.
In Erlang 27 -0.0 =/= 0.0 so updated a few tests expecting exact comparison, to use numeric equality
=. Jiffy doesn't round-trip -0.0s anyway, so it's only a test-side discrepancy.