Skip to content

Commit

Permalink
[Discover] fix functionals
Browse files Browse the repository at this point in the history
  • Loading branch information
dimaanj committed Nov 3, 2022
1 parent f38547e commit 7d00ff8
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ export interface DiscoverMainContentProps {
searchSessionManager: DiscoverSearchSessionManager;
}

const resetSearchButtonWrapper = css`
overflow: hidden;
`;

export const DiscoverMainContent = ({
isPlainRecord,
dataView,
Expand Down Expand Up @@ -115,10 +119,6 @@ export const DiscoverMainContent = ({
searchSessionManager,
});

const resetSearchButtonWrapper = css`
overflow: hidden;
`;

return (
<UnifiedHistogramLayout
className="dscPageContent__inner"
Expand Down
2 changes: 1 addition & 1 deletion test/functional/apps/discover/group1/_discover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('should modify the time range when the histogram is brushed', async function () {
// this is the number of renderings of the histogram needed when new data is fetched
// this needs to be improved
const renderingCountInc = 2;
const renderingCountInc = 1;
const prevRenderingCount = await elasticChart.getVisualizationRenderingCount();
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.discover.waitUntilSearchingHasFinished();
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ export const LensTopNavMenu = ({
currentDoc,
]);

const discoverLocator = share?.url.locators.get('discover');
const discoverLocator = share?.url.locators.get('DISCOVER_APP_LOCATOR');

const layerMetaInfo = useMemo(() => {
if (!activeDatasourceId || !discoverLocator) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ function FieldItemPopoverContents(
[indexPattern],
getEsQueryConfig(services.uiSettings)
);
const discoverLocator = services.share?.url.locators.get('discover');
const discoverLocator = services.share?.url.locators.get('DISCOVER_APP_LOCATOR');
if (!discoverLocator || !services.application.capabilities.discover.show) {
return;
}
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/lens/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ export class LensPlugin {

visualizations.registerAlias(getLensAliasConfig());

const discoverLocator = share?.url.locators.get('discover');
const discoverLocator = share?.url.locators.get('DISCOVER_APP_LOCATOR');

if (discoverLocator) {
uiActionsEnhanced.registerDrilldown(
Expand Down Expand Up @@ -499,7 +499,7 @@ export class LensPlugin {
visualizeAggBasedVisAction(core.application)
);

const discoverLocator = startDependencies.share?.url.locators.get('discover');
const discoverLocator = startDependencies.share?.url.locators.get('DISCOVER_APP_LOCATOR');

if (discoverLocator) {
startDependencies.uiActions.addTriggerAction(
Expand Down

0 comments on commit 7d00ff8

Please sign in to comment.