Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache: Add in ExpirationTime to local caches. #46

Merged
merged 3 commits into from
Apr 13, 2018
Merged

cache: Add in ExpirationTime to local caches. #46

merged 3 commits into from
Apr 13, 2018

Commits on Apr 11, 2018

  1. Add in an expiration time to the cached responses. 

    This field allows entries to expire from the cache in the case that the detectors are improved or there was a bug in the classification.

The parameter is configurable and users desiring the old behavior can set their expiration time to be a large value.
    @ewmson
    ewmson committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    7d32898 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2018

  1. Address review comments. 

    1.) Adding const
2.) Refactoring out a CACHE_VERSION
3.) Adding documentation to README
4.) Adding a special dir for the cache invalidation tests that is purged after each test.
    @ewmson
    ewmson committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    88942a1 View commit details
    Browse the repository at this point in the history

  2. Remove roll-your-own rm -r code in favor of the remove.removeSync c… 

    …all from an already imported npm module.
    @ewmson
    ewmson committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    61dd47b View commit details
    Browse the repository at this point in the history