Npm client persistent cache #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: HTTP queries are slow. We want to make as few as possible. The existing memory-only cache does not persist across different instantiations of the module, so we forget things. Solution: Introduce a persistent cache. This is now the default. Details: The cache lives in os.tmpdir(). The expected use case is on a developer's machine, where the same projects will be queried over and over. Any previously-answered queries will be resolved locally. Only newly/recently-added regexes need contact the server. Cached results do not expire. If we add new detectors or otherwise change the definition of vulnerability on the server side, we should add expiration into the client-side cache. Fix: This fixes #26.
jamesdonoh
pushed a commit
to jamesdonoh/vuln-regex-detector
that referenced
this pull request
Feb 13, 2019
Npm client persistent cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.