APISink and Extending SeqSink #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make headers as optional compact/durable/supressErrors to have default values.
davisb10
approved these changes
Mar 1, 2023
|
thanks, just one typo, instead of SeqSink, it should be APISink in the code
snippet.
[image: image.png]
… Message ID: ***@***.***
com>
|
|
I'm actually going to rework this a bit to have the bulk of the logic in the ApiSink and have SeqSink extend the ApiSink instead of the other way around. I think that will make a little more sense in the long run. |
|
You're right. I can do so if you don't have time.
…On Wed, Mar 1, 2023, 4:53 PM Brycen Davis ***@***.***> wrote:
I'm actually going to rework this a bit to have the bulk of the logic in
the ApiSink and have SeqSink extend the ApiSink instead of the other way
around. I think that will make a little more sense in the long run.
—
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEKATWODO4QHITB5YUUNGMLWZ5BDFANCNFSM6AAAAAAVKID3SM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming postToSeq to be postToLogger and refactoring. Also, making it protected instead of private to be overridden.
The ability to create a custom sink through extending SeqSink and overriding postToLogger.
Change the storage key name to be based on the toString method.
Add APISink that takes headers to be used for any custom logging