In-Tree to CSI Migration logic for PersistentVolume Attach/Detach #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm-ish, can you please squash the last commit? |
…sistent Volumes for Attach/Detach only
davidz627
force-pushed
the
feature/csiTranslationMigration
branch
from
62e8a71
to
b85bc9a
Compare
|
@jsafrane squashed, will merge now |
davidz627
pushed a commit
that referenced
this pull request
Jan 7, 2019
update from kubernetes master
davidz627
pushed a commit
that referenced
this pull request
Feb 12, 2019
update from base repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[THIS IS JUST A MERGE INTO THE FEATURE BRANCH feature/CSIMigration]
What this PR does / why we need it:
This PR "sets the stage" for in-tree to CSI Migration. It introduces the main feature flag, as well as the GCE PD Specific feature flag, the IsMigrated() Plugin interface method, as well as an implementation of the Migration for Attach/Detach for PersistentVolumes only.
This PR has been validated by turning on migration (through flags), deploying the GCE Driver (with a modified external attacher: xref kubernetes-csi/external-attacher#78), and running all the in-tree GCE PD tests and validating that the CSI driver is receiving and reacting to the attach/detach calls and that the in-tree driver is standing down for Attach/Detach.
Feature tracking issue: kubernetes/enhancements#625
/sig storage
/kind feature
/assign @jsafrane @ddebroy
/cc @msau42 @leakingtapan
Commits have been seperated out as:
Godep import of migration library
Plugin isMigratable change and boilerplate code
Feature flags and Attach/Detach migration logic