linting + pass tests

davidwaroquiers · Feb 19, 2024 · e840f9b · e840f9b
1 parent 689a616
commit e840f9b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/atomate2/abinit/jobs/base.py b/src/atomate2/abinit/jobs/base.py
@@ -191,7 +191,7 @@ def make(
         if len(task_doc.event_report.filter_types(self.critical_events)) > 0:
             task_doc = task_doc.model_copy(update={"state": TaskState.UNCONVERGED})
             task_doc.calcs_reversed[-1] = task_doc.calcs_reversed[-1].model_copy(
-                {"has_abinit_completed": TaskState.UNCONVERGED}
+                update={"has_abinit_completed": TaskState.UNCONVERGED}
             )  # optional I think
 
         return self.get_response(

diff --git a/src/atomate2/abinit/run.py b/src/atomate2/abinit/run.py
@@ -49,7 +49,7 @@ def run_abinit(
     command.append(INPUT_FILE_NAME)
 
     with open(LOG_FILE_NAME, "w") as stdout, open(STDERR_FILE_NAME, "w") as stderr:
-        process = subprocess.Popen(command, stdout=stdout, stderr=stderr, shell=False)
+        process = subprocess.Popen(command, stdout=stdout, stderr=stderr)  # noqa: S603
 
         if wall_time is not None:
             while True:

diff --git a/src/atomate2/cli/dev.py b/src/atomate2/cli/dev.py
@@ -582,13 +582,13 @@ def save_abinit_maker(maker: Maker) -> None:
     author_mail = None
     if git:
         name = subprocess.run(
-            "git config user.name".split(),
+            "git config user.name".split(),  # noqa: S603
             capture_output=True,
             encoding="utf-8",
             check=True,
         )
         mail = subprocess.run(
-            "git config user.email".split(),
+            "git config user.email".split(),  # noqa: S603
             capture_output=True,
             encoding="utf-8",
             check=True,