Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A first batch of Sonar fixes #449

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davidusb-geek
Copy link
Owner

@davidusb-geek davidusb-geek commented Feb 5, 2025

This is just a first fix batch of the issues found by Sonar.

@GeoDerp I have started this but I can see that now the 44 issues labeled as high priority are on these two files:

  • src/emhass/static/configuration_script.js
  • src/emhass/static/script.js

I may lack the js skills to solve those ;-)

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.83%. Comparing base (93f7d30) to head (08c465f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/emhass/command_line.py 54.54% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   65.79%   65.83%   +0.04%     
==========================================
  Files           8        8              
  Lines        3049     3053       +4     
==========================================
+ Hits         2006     2010       +4     
  Misses       1043     1043              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Feb 5, 2025

@GeoDerp
Copy link
Contributor

GeoDerp commented Feb 5, 2025

This is just a first fix batch of the issues found by Sonar.

@GeoDerp I have started this but I can see that now the 44 issues labeled as high priority are on these two files:

  • src/emhass/static/configuration_script.js
  • src/emhass/static/script.js
    I may lack the js skills to solve those ;-)

Will look into it when I have some free time. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants