Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-ci: added support for ppc64le #16

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

sanjaymsh
Copy link
Contributor

Hi,
I have added support for ppc64le build on travis-ci in the branch . The travis-ci build log can be tracked on the link :https://travis-ci.com/github/sanjaymsh/jax-maven-plugin/builds/191893530 . I believe it is ready for the final review and merge.
Please have a look on it.

Thanks !!

Copy link
Owner

@davidmoten davidmoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just remove oraclejdk8, oraclejdk9?

@davidmoten
Copy link
Owner

Can you tell me why you want to add support for ppc64le build? Was there doubt that it would build on that platform?

@sanjaymsh
Copy link
Contributor Author

Hi @davidmoten Reason behind running tests on ppc64le: This package is included in the ppc64le versions of RHEL and Ubuntu - this allows the top of tree to be tested continuously as it is for Intel, making it easier to catch any possible regressions on ppc64le before the distros begin their clones and builds. This reduces the work in integrating this package into future versions of RHEL/Ubuntu. So it will be required.

Thanks !!

@sanjaymsh
Copy link
Contributor Author

sanjaymsh commented Oct 23, 2020

Why don't we just remove oraclejdk8, oraclejdk9?

Yes, we can remove it. Actually i also thought the same, But then thought that may be it will be required by the community, so let put it in allow_failures case. But the thing is , these 2 are almost EOL. So we can remove it.

Thanks !!

@sanjaymsh
Copy link
Contributor Author

Done !!

@davidmoten davidmoten merged commit fc5d3b4 into davidmoten:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants