Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Davidmerwin patch 6 4 #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+95 −0
Open

Davidmerwin patch 6 4 #16

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4588fe
Create snyk-security.yml
davidmerwin Dec 29, 2023
3c56c02
Merge pull request #10 from LangMers/davidmerwin-patch-5
davidmerwin Dec 29, 2023
5c78fd2
Create greetings.yml
davidmerwin Dec 29, 2023
b5852c8
Merge branch 'main' into davidmerwin-patch-6-4
davidmerwin Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Create greetings.yml 
Signed-off-by: David Jeffrey Merwin <[email protected]>
@davidmerwin
davidmerwin authored Dec 29, 2023
commit 5c78fd2973f44125100c75e79b42eea6c95b8186
16 changes: 16 additions & 0 deletions .github/workflows/greetings.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Greetings

on: [pull_request_target, issues]

jobs:
greeting:
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
- uses: actions/first-interaction@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: "Message that will be displayed on users' first issue"
pr-message: "Message that will be displayed on users' first pull request"
Comment on lines +1 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation of GitHub Actions workflows looks good. A minor detail though — use more descriptive names for the steps. It gives a clear understanding of what each step does. Also, you can consider separate greetings for Pull Request and Issues.

jobs:
  greeting:
    steps:
    - name: First interaction
      uses: actions/first-interaction@v1
      with:
        repo-token: ${{ secrets.GITHUB_TOKEN }}
        issue-message: "Welcome to your first issue!"
        pr-message: "Congrats on your first PR!"

Comment on lines +15 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the placeholder messages with meaningful content that reflects the community guidelines and provides a warm welcome to new contributors.