-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore with wildcard pattern repetition #51
fix: restore with wildcard pattern repetition #51
Conversation
This PR is a draft because I discovered this bug through pino. The behavior in pino is different than the behavior described in #50. In pino it causes infinite recursion. Pino reproductionconst pino = require('pino');
const logger = pino({
redact: { paths: ['*.d', '*.*.d', '*.*.*.d'] },
});
const obj = {
x: { c: { d: 'hide me', e: 'leave me be' } },
y: { c: { d: 'and me', f: 'I want to live' } },
z: { c: { d: 'and also I', g: 'I want to run in a stream' } },
};
logger.info(obj);
console.log(obj); |
This seems correct |
It doesn't fix pinojs/pino#1513 |
@meirkl send a PR. |
I don't understand the status of this. We want the problem in pino resolved, right? Make it so ;). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.