Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #9 and improve performance #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Resolve #9 and improve performance #13

wants to merge 2 commits into from

Conversation

hnoson
Copy link

@hnoson hnoson commented Jul 26, 2018 •
edited
Loading

Just removed round brackets.

@hnoson hnoson mentioned this pull request Jul 26, 2018
Closed
@hnoson
Copy link
Author

hnoson commented Jul 26, 2018 •
edited
Loading

I made three changes.

  1. Add an option of git log to limit the number of logs, which makes get_time_details faster
  2. Check if there is a commit just by executing git log
  3. funcname()() -> funcname(), which resolves Time since last commit error #9

@hnoson hnoson changed the title Resolve #9 Resolve #9 and improve performance Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hnoson