Add BaseName.definition_[start,end]_position

[pappasam]

Provides two public (property) methods getting the (row, column) of the start / end of the definition range. Rows start with 1, columns start with 0.

Resolves #1576

Note: I cannot run tests locally so, unfortunately, I didn't write any. See comment in issue mentioned above.

[pappasam]

I’ll write tests soon, please don’t merge until then!

[pappasam]

@davidhalter I've added the tests!

[davidhalter]

Thanks again!

I ended up changing a few things that I didn't notice and wanted you to know:

• I'm not using properties anymore. For most things in APIs properties are a bad idea, because you cannot modify their behavior with params anymore. 2d17b81
• Used parametrize for tests, I like that better for tests in Python fa6194c
• There was an AttributeError for some cases (and the return value can be None -> so it's an Optional). 8fdf16b

[pappasam]

@davidhalter ah, gotcha, glad you caught those!

That said, the change in 8fdf16b may introduce a bug. The way I read it, if self._name.tree_name is None, the line definition = self._name.tree_name.get_definition() would raise a missing attribute exception, no?

We'd probably want the check to go:

if self._name.tree_name is None:
    return None
definition = self._name.tree_name.get_definition()
if definition is None:
    return self._name.tree_name.end_pos

Also, we'd probably also want to do this exact same check for get_definition_start_position, right?

[davidhalter]

Very good point. I think we finally arrived at a solid solution :).