With typeshed coming to Jedi, builtin modules should be displayed #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(If there's a module_path (which most will have)). This change is still backwards compatible and can be used with older Jedi versions (<0.14.0).
|
I trust you on this, but tests need to be fixed. |
pip install jedi doesn't work with properly with virtualenvs, if jedi-vim is used.
|
I think the major change is that there's now a Please review and maybe test. We can then merge. Pretty sure it works. |
|
BTW: I'm a bit unsure about the test failures. If you have any idea, I'm interested. |
str has different signatures for Python 2 and 3 and is therefore annoying to test.
|
Tests are passing now. I feel like I finally fixed it. |
|
Awesome! |
blueyed
approved these changes
Jun 22, 2019
This was referenced Jun 22, 2019
|
Not sure what you intend to do now. Are you merging once you tested it for a bit? Or was your idea that I merge it? |
|
Feel free to merge it already (the approval is based on reviewing). |
|
Merging, worst case we revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If there's a module_path, which most will have)
This change is still backwards compatible and can be used with older Jedi
versions (<0.14.0).
We can merge this now or later. IMO it's good to merge now, because it won't really change the behavior AFAIK.