Skip to content

Commit

Permalink
With typeshed coming to Jedi, builtin modules should be displayed
Browse files Browse the repository at this point in the history
(If there's a module_path (which most will have)).

This change is still backwards compatible and can be used with older Jedi
versions (<0.14.0).
  • Loading branch information
davidhalter committed Mar 9, 2019
1 parent 1f7e661 commit 23c14f6
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions pythonx/jedi_vim.py
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ def goto(mode="goto"):
echo_highlight("Couldn't find any definitions for this.")
elif len(definitions) == 1 and mode != "related_name":
d = list(definitions)[0]
if d.in_builtin_module():
if d.module_path is None:
if d.is_keyword:
echo_highlight("Cannot get the definition of Python keywords.")
else:
Expand Down Expand Up @@ -372,9 +372,7 @@ def show_goto_multi_results(definitions):
"""Create a quickfix list for multiple definitions."""
lst = []
for d in definitions:
if d.in_builtin_module():
lst.append(dict(text=PythonToVimStr('Builtin ' + d.description)))
elif d.module_path is None:
if d.module_path is None:
# Typically a namespace, in the future maybe other things as
# well.
lst.append(dict(text=PythonToVimStr(d.description)))
Expand Down Expand Up @@ -740,7 +738,7 @@ def py_import():
except IndexError:
echo_highlight('Cannot find %s in sys.path!' % import_path)
else:
if completion.in_builtin_module():
if completion.module_path is None:
echo_highlight('%s is a builtin module.' % import_path)
else:
cmd_args = ' '.join([a.replace(' ', '\\ ') for a in args])
Expand Down

0 comments on commit 23c14f6

Please sign in to comment.