feat: ShuffleState and QuarterRound AVX2 and SSE3 #154
14 new issues (0 max.) of at least minor severity.
Issues
======
+ Solved 3
- Added 14
Complexity increasing per file
==============================
- test/NaCl.Core.Benchmarks/XSalsa20Benchmark.cs 1
- test/NaCl.Core.Benchmarks/Salsa20Benchmark.cs 1
Complexity decreasing per file
==============================
+ test/NaCl.Core.Benchmarks/Program.cs -1
Clones added
============
- test/NaCl.Core.Benchmarks/XSalsa20Benchmark.cs 2
- test/NaCl.Core.Benchmarks/Salsa20Benchmark.cs 4
- test/NaCl.Core.Tests/Salsa20Tests.cs 1
- test/NaCl.Core.Benchmarks/XChaCha20Benchmark.cs 1
- test/NaCl.Core.Tests/ChaCha20Tests.cs 1
Clones removed
==============
+ src/NaCl.Core/Base/Salsa20Base.cs -1
+ src/NaCl.Core/Base/ChaCha20Base.cs -1
See the complete overview on Codacy
Annotations
Check warning on line 83 in src/NaCl.Core/Base/ChaCha20Base.cs
codacy-production / Codacy Static Code Analysis
src/NaCl.Core/Base/ChaCha20Base.cs#L83
Remove this commented out code.
Check warning on line 435 in src/NaCl.Core/Base/ChaCha20Base.cs
codacy-production / Codacy Static Code Analysis
src/NaCl.Core/Base/ChaCha20Base.cs#L435
Remove this commented out code.
Check notice on line 17 in test/NaCl.Core.Benchmarks/ChaCha20Benchmark.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Benchmarks/ChaCha20Benchmark.cs#L17
Remove the field '_key' and declare it as a local variable in the relevant methods.
Check notice on line 20 in test/NaCl.Core.Benchmarks/ChaCha20Benchmark.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Benchmarks/ChaCha20Benchmark.cs#L20
Remove the field '_cipherText' and declare it as a local variable in the relevant methods.
Check notice on line 16 in test/NaCl.Core.Benchmarks/Salsa20Benchmark.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Benchmarks/Salsa20Benchmark.cs#L16
Remove the field '_key' and declare it as a local variable in the relevant methods.
Check warning on line 68 in test/NaCl.Core.Benchmarks/Salsa20Benchmark.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Benchmarks/Salsa20Benchmark.cs#L68
Remove this commented out code.
Check notice on line 17 in test/NaCl.Core.Benchmarks/XChaCha20Benchmark.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Benchmarks/XChaCha20Benchmark.cs#L17
Remove the field '_key' and declare it as a local variable in the relevant methods.
Check notice on line 20 in test/NaCl.Core.Benchmarks/XChaCha20Benchmark.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Benchmarks/XChaCha20Benchmark.cs#L20
Remove the field '_cipherText' and declare it as a local variable in the relevant methods.
Check notice on line 14 in test/NaCl.Core.Benchmarks/XSalsa20Benchmark.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Benchmarks/XSalsa20Benchmark.cs#L14
Remove the field '_key' and declare it as a local variable in the relevant methods.
Check warning on line 66 in test/NaCl.Core.Benchmarks/XSalsa20Benchmark.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Benchmarks/XSalsa20Benchmark.cs#L66
Remove this commented out code.
Check failure on line 234 in test/NaCl.Core.Tests/ChaCha20Tests.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Tests/ChaCha20Tests.cs#L234
Add curly braces around the nested statement(s) in this 'if' block.
Check failure on line 255 in test/NaCl.Core.Tests/ChaCha20Tests.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Tests/ChaCha20Tests.cs#L255
Add curly braces around the nested statement(s) in this 'if' block.
Check warning on line 273 in test/NaCl.Core.Tests/Salsa20Tests.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Tests/Salsa20Tests.cs#L273
Make sure using this hardcoded IP address '00:00:00:09:00:00:00:4a' is safe here.
Check notice on line 282 in test/NaCl.Core.Tests/Salsa20Tests.cs
codacy-production / Codacy Static Code Analysis
test/NaCl.Core.Tests/Salsa20Tests.cs#L282
Remove the array size specification; it is redundant.