Fix minor issues found during testing #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsortium#428) * Update snwgrain implementation to fix bug in snow sublimation - fix bug in sublimation of snow - check allocation of snow aging table needed for E3SM, reported by NJ. * Update snowage array allocation checks
- icedrv_init write format for history_format - dims allocation in icedrv_restart - cleaned up some intent lines (old) - add return at end of io_suite.ts - update namelist documentation of history_format, restart_format Update to current main trunk
|
I'm PRing some fixes to your branch. After testing, decided it would be easier to just PR than report. If you merge this, it should immediately be part of CICE-Consortium#427. |
6 tasks
Check history_format and restart_format input values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Short (1 sentence) summary of your PR:
Fix minor issues found during testing
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
full icepack test suite on cheyenne with intel, gnu, pgi passes versus current CICE-Consortium main
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Fix minor issues found during testing
- icedrv_init write format for history_format
- dims allocation in icedrv_restart
- cleaned up some intent lines (old)
- add return at end of io_suite.ts
- update namelist documentation of history_format, restart_format
Update to current main trunk