support AMD #46
Merged
support AMD #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi David,
I'm happy you've done this. I've moved past this problem now and I don't
have time to go back and work on it again. I'm sorry not to help.
…On Tue, 23 Apr 2019 at 18:36, David Chambers ***@***.***> wrote:
Closes #40 <#40>
@cja-github <https://github.com/cja-github>, could you confirm that these
changes work for you? If so, I will publish a new version of the package so
you will no longer need to apply a patch. :)
------------------------------
You can view, comment on, or merge this pull request online at:
#46
Commit Summary
- support AMD
File Changes
- *M* Makefile
<https://github.com/davidchambers/Base64.js/pull/46/files#diff-0> (2)
- *M* README.md
<https://github.com/davidchambers/Base64.js/pull/46/files#diff-1> (2)
- *M* base64.js
<https://github.com/davidchambers/Base64.js/pull/46/files#diff-2> (43)
Patch Links:
- https://github.com/davidchambers/Base64.js/pull/46.patch
- https://github.com/davidchambers/Base64.js/pull/46.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABIIJTYCILFULZZ7SIY5A2DPR43H5ANCNFSM4HH3KPFA>
.
--
Christopher Alexander
[email protected]
|
|
No problem, @cja-github. I merged this pull request in case it proves useful to someone else. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
@cja-github, could you confirm that these changes work for you? If so, I will publish a new version of the package so you will no longer need to apply a patch. :)