Adobe ExtendScript errors #32
Conversation
|
Thank you for submitting this pull request, @SheetJSDev! |
base64.js
Outdated
| @@ -37,7 +37,7 @@ | |||
| // [https://gist.github.com/1020396] by [https://github.com/atk] | |||
| object.atob || ( | |||
| object.atob = function (input) { | |||
| var str = String(input).replace(/=+$/, ''); | |||
| var str = String(input).replace(new RegExp("=+$"), ''); // #31: ExtendScript bad parse of /= | |||
There was a problem hiding this comment.
Did you see @michaelficarra's suggestion in #31? It strikes me as a nice approach. Another option is /[=]+$/ (I just tested it in ExtendScript Toolkit).
I'm happy with any of these three fixes. @michaelficarra, do you have a preference?
There was a problem hiding this comment.
@davidchambers /[=]+$/ is probably ubiquitous since any reasonable regexp library will support character sets. I don't know what engines support non-capture groups (which was @michaelficarra 's suggestion)
In the interest of parsimony /[=]+$/ only adds 2 characters to the output while /(?:)=+$/ adds 4 and new RegExp adds many more, so that is probably the best option
There was a problem hiding this comment.
If we come to a consensus I can change the commit, but let's wait for @michaelficarra to chime in first.
base64.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| ;(function () { | |||
|
|
|||
| var object = typeof exports != 'undefined' ? exports : self; // #8: web workers | |||
| var object = typeof exports != 'undefined' ? exports : typeof self != 'undefined' ? self : (1,eval)('this'); // #8: web workers, #31: ExtendScript | |||
There was a problem hiding this comment.
Does this work for you? For me,
(function() { return (1, eval)('this'); }())evaluates to a reference to the anonymous function. On the other hand,
(function(global) { return global; }(this))evaluates to the global object.
Now that we have three cases we could reformat the ternary expressions to improve readability. I suggest something along these lines:
var object =
typeof exports != 'undefined' ? exports :
typeof self != 'undefined' ? self :
/* otherwise */ ...;There was a problem hiding this comment.
@davidchambers 1,eval trick works in the illustrator context but not in the photoshop context. I couldn't get your function working either. So I went back to the docs https://wwwimages2.adobe.com/content/dam/Adobe/en/devnet/scripting/pdfs/javascript_tools_guide.pdf and it says $.global should be available everywhere.
Can you check if $.global works for you?
Also, what should happen if none of the variables are available? The original code assumed self was available
There was a problem hiding this comment.
Can you check if
$.globalworks for you?
It does. Let's use it!
Also, what should happen if none of the variables are available?
I'm happy to leave the behaviour unspecified.
Fixes #31: - ES parses `/=+$/` as a division-assignment - fallback to $.global if `self` and `exports` are not available
|
Amended commit with the discussed changes. Thanks @davidchambers for looking into this on a Saturday :) |
|
Released as 1.0.1. Thank you for the thoughtful pull request, @SheetJSDev. :) |
Fixes #31:
/=+$/as a division-assignment; replace with new RegExpselfandexportsare not available