Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing logging api and supporting Pluto #96

Merged
merged 1 commit into from
Mar 9, 2022
Merged

fixing logging api and supporting Pluto #96

merged 1 commit into from
Mar 9, 2022

Conversation

PavanChaggar
Copy link
Contributor

When using GaussianMixtures.jl in Pluto, one receives the following error:

gmm
type PlutoLogger has no field min_level
getproperty(::Main.PlutoRunner.PlutoLogger, ::Symbol)@Base.jl:42
var"#GMMk#11"(::Symbol, ::Int64, ::Int64, ::Int64, ::typeof(GaussianMixtures.GMMk), ::Int64, ::Matrix{Float64})@train.jl:103
#GMM#[email protected]:37[inlined]
[email protected]:32[inlined]
top-level scope@[Local: 1](http://localhost:1234/edit?id=eab1dbc0-9e53-11ec-1b37-75a82665b36b#)[inlined]

This is the same issue documented here in Pluto.jl and addressed #90 in GaussianMixtures.jl.

The issue seems to be in src/train.jl where .min_level is used, which is part of an internal api. The fix is the same as here, which switches out .min_level for the corresponding standard interface, `Logging.min_enabled_level().

I dont think this should change anything regarding tests and all test are passing on my local machine.

Let me know if you'd like anything else added.

@PavanChaggar PavanChaggar mentioned this pull request Mar 8, 2022
@davidavdav davidavdav merged commit 4fe4f08 into davidavdav:main Mar 9, 2022
@davidavdav
Copy link
Owner

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants