fixing logging api and supporting Pluto #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using GaussianMixtures.jl in Pluto, one receives the following error:
This is the same issue documented here in Pluto.jl and addressed #90 in GaussianMixtures.jl.
The issue seems to be in
src/train.jl
where.min_level
is used, which is part of an internal api. The fix is the same as here, which switches out.min_level
for the corresponding standard interface, `Logging.min_enabled_level().I dont think this should change anything regarding tests and all test are passing on my local machine.
Let me know if you'd like anything else added.