Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic peer service specification #4

Closed
wants to merge 15 commits into from
Closed

Conversation

david4096
Copy link
Owner

@david4096 david4096 commented Dec 15, 2016

Describes a basic peer service listing functionality. Servers are expected to implement their own method for managing the list of peers.

Bump target version
Grammar
@david4096
Copy link
Owner Author

david4096 commented Jan 7, 2017

@dcolligan @ejacox @kozbo

See the resulting documentation here.

Please take a look and I'll move this over to a PR at ga4gh. Edwin, we'll use some subset of the document you wrote for the human readable portion of the .rst documentation portion of the PR.

Currently facing an error related to how process schemas is inserting paths. https://travis-ci.org/david4096/schemas/builds/189684702

This could be worked around by removing the info fields, or describing the messages in another file. If "better attributes" goes in first we won't be bothered by it.

@ejacox
Copy link

ejacox commented Jan 8, 2017

Are we ready to move forward with this? If so, the comments should be cleaned up and adhere more to what we wrote in the documentation. What are "better attributes"?

@david4096
Copy link
Owner Author

david4096 commented Jan 8, 2017

Yes, as far as I'm concerned.

Better attributes schema pull request replaces the info field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants